Refactor projection binding to avoid redundant Convert nodes and impr…#37625
Open
Abde1rahman1 wants to merge 4 commits intodotnet:mainfrom
Open
Refactor projection binding to avoid redundant Convert nodes and impr…#37625Abde1rahman1 wants to merge 4 commits intodotnet:mainfrom
Abde1rahman1 wants to merge 4 commits intodotnet:mainfrom
Conversation
…ove NativeAOT compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Core Expression Enhancements
ProjectionBindingExpression: Introduced the UpdateType(Type type) method. Since Expressions are immutable, this allows creating a new instance with a refined type. This is crucial for changing the "expected type" of a projection without wrapping it in a UnaryExpression (Convert node).
Shaper Logic Optimization
ProjectionBindingExpressionVisitor.MatchTypes: Updated the logic to check if an expression is a ProjectionBindingExpression. Instead of returning Expression.Convert(expression, targetType), it now calls projectionBindingExpression.UpdateType(targetType). This results in a much flatter and cleaner shaper expression tree.
Provider Clean-up (Relational & Cosmos)
RelationalProjectionBindingExpressionVisitor: Removed several calls to .MakeNullable(). By passing the raw expression.Type, we avoid unnecessary MakeGenericType calls, which is a significant win for NativeAOT and trimming. The MatchTypes logic now handles necessary conversions more intelligently.
CosmosProjectionBindingExpressionVisitor: Applied the same clean-up to the Cosmos provider, bringing it up to parity with the relational implementation.
Fixes ##36572